[testbed] Passing processor configs in a struct slice to preserve order #35064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Sep 11, 2024
swamisriman
force-pushed
the
testbed/proc_order_fix
branch
from
0253077
to
5e79127
Compare
swamisriman
changed the title
swamisriman
force-pushed
the
testbed/proc_order_fix
branch
from
5e79127
to
0a8168e
Compare
|
@atoulme |
swamisriman
force-pushed
the
testbed/proc_order_fix
branch
from
0a8168e
to
2fa487f
Compare
crobert-1
reviewed
Sep 30, 2024
There was a problem hiding this comment.
From failing lint run:
Error: testbed/correctnesstests/connectors/correctness_test.go:25:3: composites: github.com/open-telemetry/opentelemetry-collector-contrib/testbed/correctnesstests.ProcessorNameAndConfigBody struct literal uses unkeyed fields (govet)
{
^
Error: testbed/correctnesstests/traces/correctness_test.go:29:3: composites: github.com/open-telemetry/opentelemetry-collector-contrib/testbed/correctnesstests.ProcessorNameAndConfigBody struct literal uses unkeyed fields (govet)
{
^
Error: testbed/stabilitytests/trace_test.go:28:3: composites: github.com/open-telemetry/opentelemetry-collector-contrib/testbed/tests.ProcessorNameAndConfigBody struct literal uses unkeyed fields (govet)
{
swamisriman
force-pushed
the
testbed/proc_order_fix
branch
from
2fa487f
to
d8f51ee
Compare
|
Hi @crobert-1 |
swamisriman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, the processor config was passed as a map, because of which preserving the processor was not possible.
Changed the data type to a newly added struct slice so that the processors are used in the supplied order.
NOTE that this change is breaking - if any of these changed functions are directly used, they will break as existing usages supply map.
Link to tracking Issue:
Resolves #33003