[receiver/webhookevent] fix for issue 35028 #35065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalper2
changed the title
shalper2
force-pushed
the
35028-fix-scan-behavior
branch
2 times, most recently
from
fee8f5d
to
b5fc5b4
Compare
crobert-1
approved these changes
Sep 12, 2024
shalper2
force-pushed
the
35028-fix-scan-behavior
branch
2 times, most recently
from
57f73f6
to
ed26e5e
Compare
atoulme
approved these changes
Sep 17, 2024
atoulme
added
the
ready to merge
shalper2
force-pushed
the
35028-fix-scan-behavior
branch
2 times, most recently
from
8386425
to
e3a7a6a
Compare
atoulme
removed
the
ready to merge
shalper2
force-pushed
the
35028-fix-scan-behavior
branch
2 times, most recently
from
7aa0d99
to
5ac8841
Compare
|
@open-telemetry/collector-contrib-approvers This is ready to merge, I think |
crobert-1
added
the
ready to merge
shalper2
force-pushed
the
35028-fix-scan-behavior
branch
2 times, most recently
from
8c92ae7
to
b5d4b83
Compare
shalper2
force-pushed
the
35028-fix-scan-behavior
branch
from
b5d4b83
to
71777fc
Compare
codeboten
approved these changes
Oct 2, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
**Description:** Fixed a bug where request bodies containing newlines caused logs to split into separate entries. **Link to tracking Issue:** [35028](open-telemetry#35028) **Testing:** Added a new unit test to `req_to_log_test.go` for the case where request body data contains newline characters **Documentation:** Some comments in `req_to_log.go` for clarity were added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixed a bug where request bodies containing newlines caused logs to split into separate entries.
Link to tracking Issue: 35028
Testing: Added a new unit test to
req_to_log_test.gofor the case where request body data contains newline charactersDocumentation: Some comments in
req_to_log.gofor clarity were added.