[pkg/pmetrictest] option to ignore float precision discrepancies when using CompareMetrics
#35085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dont think this one needs a changelog entry but let me know if it does and I'll get one added. And should I be addressing this? Or is this failing for other reasons? |
atoulme
approved these changes
Sep 10, 2024
djaglowski
approved these changes
Sep 11, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
… using `CompareMetrics` (open-telemetry#35085) **Description:** <Describe what has changed.> Addresses issue: open-telemetry#35060 Adds option to `CompareMetrics` testing function that rounds floats to an arbitrary number of decimals. This is needed to avoid issues with float precision during testing. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#35060 **Testing:** <Describe what testing was performed and which tests were added.> Test and test data added for this CompareMetrics option **Documentation:** No new docs. Let me know if I should be adding something somewhere! Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Addresses issue: #35060
Adds option to
CompareMetricstesting function that rounds floats to an arbitrary number of decimals. This is needed to avoid issues with float precision during testing.Link to tracking Issue:
#35060
Testing:
Test and test data added for this CompareMetrics option
Documentation:
No new docs. Let me know if I should be adding something somewhere!