[receiver/datadog][bug-fix] Add DD span metrics as attributes
#35087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopes-felipe
requested review from
jpkrohling and
MovieStoreGuy
as code owners
|
Test failing due to this unrelated issue. |
|
@jpkrohling @MovieStoreGuy, would you mind reviewing this? It's a pretty straightforward change. Thank you :) |
|
Thank you for the review @jpkrohling. Any chances we get this merged as well? |
carrieedwards
approved these changes
Sep 19, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…-telemetry#35087) **Description:** <Describe what has changed.> Datadog [divides the span's tags](https://github.com/DataDog/dd-trace-java/blob/master/dd-trace-core/src/main/java/datadog/trace/common/writer/ddagent/TraceMapperV0_5.java#L210-L212) into [two fields](https://github.com/DataDog/datadog-agent/blob/1739a048156d968bbe5fd8a1ace8e07c997d16d9/pkg/proto/datadog/trace/span.proto#L50-L55), `meta` for string values and `metrics` for numeric ones. Currently, the receiver isn't considering the `metrics` field when building the OTel span's attributes, losing this metadata during the conversion. This PR fixes this issue. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Datadog divides the span's tags into two fields,
metafor string values andmetricsfor numeric ones.Currently, the receiver isn't considering the
metricsfield when building the OTel span's attributes, losing this metadata during the conversion. This PR fixes this issue.Link to tracking Issue:
Testing:
Documentation: