[chore][graph] Remove connectorNode's separate baseConsumer #11333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11333 +/- ##
==========================================
+ Coverage 91.91% 92.01% +0.10%
==========================================
Files 430 430
Lines 20342 20306 -36
==========================================
- Hits 18697 18685 -12
+ Misses 1271 1259 -12
+ Partials 374 362 -12 ☔ View full report in Codecov by Sentry. |
djaglowski
force-pushed
the
connector-node-unify-component
branch
2 times, most recently
from
ea7269e
to
1aac88d
Compare
bogdandrutu
approved these changes
Oct 9, 2024
djaglowski
force-pushed
the
connector-node-unify-component
branch
from
1aac88d
to
4332126
Compare
djaglowski
added
the
ready-to-merge
bogdandrutu
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #11330
Currently,
connectorNodecontains separatecomponent.ComponentandbaseConsumerfields. These fields are essentially two representations of the same component, butbaseConsumermay be wrapped in another consumer that inherits capabilities. Rather than maintain two separate handles, this PR switches to a unified field. I believe this change helps normalize the connector node with other types of consumer nodes and will enable further refactoring opportunities.