Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #11348

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Fix typos #11348

merged 4 commits into from
Oct 9, 2024

Conversation

NathanBaulch
Copy link
Contributor

@NathanBaulch NathanBaulch commented Oct 4, 2024

Just thought I'd contribute some typo fixes I stumbled upon. Nothing controversial (hopefully), just 72 simple fixes.

Use the following command to get a quick and dirty summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the top typos are:

  • invokable (16)
  • subsciption (15)
  • decison (7)
  • reques (3)
  • dissallow (3)
  • documenation (3)
  • locahost (3)
  • prerequistes (2)
  • assinged (2)
  • extenions (2)

@NathanBaulch NathanBaulch requested a review from a team as a code owner October 4, 2024 04:14
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.91%. Comparing base (5ac1607) to head (ccdd9da).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/mdatagen/internal/command.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11348   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         432      432           
  Lines       20350    20350           
=======================================
  Hits        18705    18705           
  Misses       1271     1271           
  Partials      374      374           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 4, 2024
internal/globalgates/globalgates.go Outdated Show resolved Hide resolved
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, just a couple of suggestions

internal/globalgates/globalgates.go Outdated Show resolved Hide resolved
semconv/v1.27.0/generated_attribute_group.go Show resolved Hide resolved
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten merged commit 42e6304 into open-telemetry:main Oct 9, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 9, 2024
@NathanBaulch NathanBaulch deleted the typos branch October 10, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants