Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version init #11388

Merged
merged 4 commits into from
Oct 8, 2024
Merged

fix version init #11388

merged 4 commits into from
Oct 8, 2024

Conversation

luccabb
Copy link
Contributor

@luccabb luccabb commented Oct 7, 2024

Description

debug.ReadBuildInfo()

returns an error for some environments, which then panics on info.Main.Version:

panic: runtime error: invalid memory address or nil pointer dereference

this fixes the issue by only updating the version if debug.ReadBuildInfo() succeeds

@luccabb luccabb requested a review from a team as a code owner October 7, 2024 22:46
@luccabb luccabb requested a review from atoulme October 7, 2024 22:46
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.90%. Comparing base (5f4f2c2) to head (267961a).

Files with missing lines Patch % Lines
cmd/builder/internal/version.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11388      +/-   ##
==========================================
- Coverage   91.92%   91.90%   -0.03%     
==========================================
  Files         430      430              
  Lines       20311    20313       +2     
==========================================
- Hits        18671    18668       -3     
- Misses       1267     1270       +3     
- Partials      373      375       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 8, 2024
@songy23 songy23 added Skip Contrib Tests ready-to-merge Code review completed; ready to merge by maintainers labels Oct 8, 2024
@bogdandrutu bogdandrutu merged commit 0f81b78 into open-telemetry:main Oct 8, 2024
47 of 57 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 8, 2024
@luccabb luccabb deleted the fix_version_init branch October 8, 2024 20:12
@luccabb
Copy link
Contributor Author

luccabb commented Oct 8, 2024

@bogdandrutu @codeboten @songy23

any chance of a v0.111.1 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants