-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix version init #11388
Merged
Merged
fix version init #11388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Oct 8, 2024
bogdandrutu
approved these changes
Oct 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11388 +/- ##
==========================================
- Coverage 91.92% 91.90% -0.03%
==========================================
Files 430 430
Lines 20311 20313 +2
==========================================
- Hits 18671 18668 -3
- Misses 1267 1270 +3
- Partials 373 375 +2 ☔ View full report in Codecov by Sentry. |
songy23
reviewed
Oct 8, 2024
codeboten
approved these changes
Oct 8, 2024
…o fix_version_init
songy23
added
Skip Contrib Tests
ready-to-merge
Code review completed; ready to merge by maintainers
labels
Oct 8, 2024
bogdandrutu
approved these changes
Oct 8, 2024
@bogdandrutu @codeboten @songy23 any chance of a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
Code review completed; ready to merge by maintainers
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Skip Contrib Tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
returns an error for some environments, which then panics on
info.Main.Version
:this fixes the issue by only updating the version if
debug.ReadBuildInfo()
succeeds