Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the test compatibility check even if tests failed #6224

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Run the test compatibility check even if tests failed #6224

merged 3 commits into from
Oct 10, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Oct 9, 2024 •
edited
Loading

This forces the test compatibility check to run, even if compatibility test checks have failed, as having it skipped still allows merging PRs.

Screenshot 2024-10-09 at 13 45 05 Screenshot 2024-10-09 at 13 45 24

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Oct 9, 2024
@dmathieu dmathieu marked this pull request as ready for review October 9, 2024 11:45
@dmathieu dmathieu requested a review from a team as a code owner October 9, 2024 11:45
@dmathieu dmathieu mentioned this pull request Oct 9, 2024
Open
@dmathieu dmathieu merged commit 900fc4b into open-telemetry:main Oct 10, 2024
23 of 24 checks passed
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@pellared pellared pellared approved these changes

Assignees
No one assigned
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dmathieu @dashpole @pellared @MrAlias