Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Exponential Histogram Aggregator. #4245

Merged
merged 34 commits into from
Aug 4, 2023

Remove DefaultExponentialHistogram()

581c7d6
Select commit
Loading
Failed to load commit list.
Merged

Add the Exponential Histogram Aggregator. #4245

Remove DefaultExponentialHistogram()
581c7d6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 4, 2023 in 1s

83.6% (+0.5%) compared to f67ecb3

View this Pull Request on Codecov

83.6% (+0.5%) compared to f67ecb3

Details

Codecov Report

Merging #4245 (581c7d6) into main (f67ecb3) will increase coverage by 0.5%.
The diff coverage is 90.7%.

❗ Current head 581c7d6 differs from pull request most recent head dfc13fd. Consider uploading reports for the commit dfc13fd to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4245     +/-   ##
=======================================
+ Coverage   83.0%   83.6%   +0.5%     
=======================================
  Files        217     186     -31     
  Lines      17166   14705   -2461     
=======================================
- Hits       14264   12299   -1965     
+ Misses      2611    2178    -433     
+ Partials     291     228     -63     
Files Changed Coverage Δ
sdk/metric/internal/aggregate/aggregate.go 81.3% <0.0%> (-18.7%) ⬇️
sdk/metric/pipeline.go 88.6% <10.0%> (-2.2%) ⬇️
sdk/metric/aggregation/aggregation.go 82.2% <78.5%> (-1.7%) ⬇️
...metric/internal/aggregate/exponential_histogram.go 98.0% <98.0%> (ø)

... and 57 files with indirect coverage changes