otlpmetricgrpc: Keep metadata for gRPC in context #5892
Merged
+15
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using otlpmetricgrpc, we can inject metadata dynamically with
metadata.AppendToOutgoingContext
. However when specifying headers withWithHeaders
, it becomes impossible to add additional metadata.For example, the code below sends additional metadata in the header
But when using
WithHeader
like below, no additional metadata will be sentTo eliminate this inconsistency, keep the metadata in the context and send them in the header.