Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry-disk-buffering to use protobuf-javalite #1009

Closed
danielbanks opened this issue Aug 21, 2023 · 3 comments
Closed

Update opentelemetry-disk-buffering to use protobuf-javalite #1009

danielbanks opened this issue Aug 21, 2023 · 3 comments

Comments

@danielbanks
Copy link

danielbanks commented Aug 21, 2023

Description

When using io.opentelemetry.contrib:opentelemetry-disk-buffering on Android and the [protodatastore] library(https://developer.android.com/topic/libraries/architecture/datastore), we get dependency resolution errors.

Protodatastore is a library provided by Google used by many Android applications.

The Android library is built using,
com.google.protobuf:protobuf-kotlin-lite:

which in turn consumes,
com.google.protobuf:protobuf-javalite

The issue is that the disk buffering lib consumes,
com.google.protobuf:protobuf-java,
rather than the light version.

This means we get duplicate classes found and a build time dependency resolution error.

Describe the solution you'd like

Given that the lite version of this is optimized for mobile and also that Mobile applications are most likely to make use of this disk export, can we upgrade the disk buffering library to use the lite version? Or provide an alternative that depends upon protobuf-javalite?

@danielbanks
Copy link
Author

@LikeTheSalad I raised a feature request as per our discussion on slack :)

@LikeTheSalad
Copy link
Contributor

Hi! - This issue should be fixed by #1008 which will be available in the next release (1.30.0-alpha if I'm not mistaken).

@trask
Copy link
Member

trask commented Sep 18, 2023

1.30.0-alpha is just now released

@trask trask closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants