Add kafka.request.time.avg #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds metric `kafka.request.time.avg` for `kafka.network:type=RequestMetrics,name=TotalTimeMs,request={Produce,FetchConsumer,FetchFollower}`. It does so by collecting from the `Mean` attribute.`
breedx-splk
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Thanks @mackjmr . I'm ok with this approach. It's not your fault, but I'm a little bummed that each of these aggregations is split out into its own metric...but it's the existing pattern, and it's what we have for now.
|
Thanks for the review @breedx-splk, is this good to be merged ? |
|
@open-telemetry/java-contrib-maintainers little help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds metric
kafka.request.time.avgforkafka.network:type=RequestMetrics,name=TotalTimeMs,request={Produce,FetchConsumer,FetchFollower}. It does so by collecting from theMeanattribute.Existing Issue(s):
This is a small addition so didn't open an issue.
Testing:
Added test case in
KafkaIntegrationTest.javaDocumentation:
Added documentation in
kafka.mdOutstanding items:
< Anything that these changes are intentionally missing
that will be needed or can be helpful in the future. >