Add GCP resource detection module #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuereth
approved these changes
Jan 19, 2024
SylvainJuge
approved these changes
Jan 22, 2024
gcp-resources/src/test/java/io/opentelemetry/contrib/gcp/resource/GCPResourceProviderTest.java
Outdated
Show resolved
Hide resolved
gcp-resources/src/test/java/io/opentelemetry/contrib/gcp/resource/GCPResourceProviderTest.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Jan 25, 2024
|
can you add the new module to here also? |
psx95
force-pushed
the
add-gcp-resource-detection
branch
from
ca7a14c
to
12bd584
Compare
psx95
force-pushed
the
add-gcp-resource-detection
branch
from
12bd584
to
d81dd21
Compare
Done! Thank you for the review ! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Google Cloud Resource Detection Module
Moves the existing google cloud resource detectors from GoogleCloudPlatform/opentelemetry-operations-java to open-telemetry/opentelemetry-java-contrib.
Existing Issue(s):
Testing:
./gradlew assemble && ./gradlew :gcp-resources:testDocumentation:
Javadoc and README explaining the purpose of the module added.
Outstanding items:
Update the component owners file.