migrate maven extension to current semconv #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry @cyrille-leclerc this probably overlaps quite a lot with your work in this draft PR #1060 which I just found by browsing the open PRs, however this one might be easier to review and merge by being much simpler and smaller. |
|
And I also found this other PR: #1059 from last September where you mentioned having an opt-in option to allow it to continue using current semconv. However, to my knowledge all other modules in this repo tend to use the current version of semconv. |
|
Thank you very much @SylvainJuge, your PR looks great. I hope the code was enjoyable to read. |
cyrille-leclerc
approved these changes
May 2, 2024
laurit
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Maven extension relies on an older version of semantic conventions and an explicit exception was added in #1070.
This PR aligns maven extension with the new version of semconv.
Replaces #1055 that has become obsolete with current state of semconv.
Overlaps with #1059 but is simpler so easier to review and merge short term.