Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove okhttp3 as dependency #1351 #1364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

driverpt
Copy link

@driverpt driverpt commented Jul 5, 2024

Description:
Removed Okhttp3 dependency. Okhttp3 brings Kotlin into the classpath and some of us do not want to bring Kotlin into the classpath as it creates "dependency hell"

Existing Issue(s):
#1351

Testing:
Tested Locally (No EKS Scenario) with OTLP Exporter

Documentation:
N/A

Outstanding items:
If someone could please test EKSResource and SSLSocketFactory, would be appreciated.

@driverpt driverpt requested a review from a team July 5, 2024 16:32
@github-actions github-actions bot requested review from srprash and wangzlei July 5, 2024 16:32
@trask
Copy link
Member

trask commented Jul 9, 2024

hi @driverpt! check out the discussion in #1061

also, it may be worth waiting for open-telemetry/opentelemetry-java#6546 to land and get released (cc @SylvainJuge)

@driverpt
Copy link
Author

driverpt commented Jul 9, 2024

Is there an ETA when this can be reviewed and possibly merged? This is causing us some classpath hell in Micronaut + GraalVM

@trask
Copy link
Member

trask commented Jul 9, 2024

Is there an ETA when this can be reviewed and possibly merged?

are you asking about this PR, or open-telemetry/opentelemetry-java#6546? were you able to read through the concerns expressed in #1061? thanks

@driverpt
Copy link
Author

This PR

@driverpt driverpt force-pushed the aws-resource-remove-okhttp-3 branch from 19c0b8f to 58e1e54 Compare July 18, 2024 08:22
@trask
Copy link
Member

trask commented Jul 18, 2024

@driverpt I think this is a good idea, we just still need to address the concerns raised in #1061

@trask
Copy link
Member

trask commented Oct 17, 2024

I think this can move forward now using the new internal API that was introduced in open-telemetry/opentelemetry-java#6546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants