Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add declarative config support for RuleBasedRoutingSampler #1440

Merged
merged 7 commits into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions samplers/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,62 @@
# Samplers

## Declarative configuration

The following samplers support [declarative configuration](https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/configuration#declarative-configuration):

* `RuleBasedRoutingSampler`

To use:

* Add a dependency on `io.opentelemetry:opentelemetry-sdk-extension-incubator:<version>`
* Follow the [instructions](https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/incubator/README.md#file-configuration) to configure OpenTelemetry with declarative configuration.
* Configure the `.tracer_provider.sampler` to include the `rule_based_routing` sampler.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: add usage instructions for otel java agent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Schema for `rule_based_routing` sampler:

```yaml
# The fallback sampler to the use if the criteria is not met.
fallback_sampler:
always_on:
# Filter to spans of this span_kind. Must be one of: SERVER, CLIENT, INTERNAL, CONSUMER, PRODUCER.
span_kind: SERVER # only apply to server spans
# List of rules describing spans to drop. Spans are dropped if they match one of the rules.
rules:
# The action to take when the rule is matches. Must be of: DROP, RECORD_AND_SAMPLE.
- action: DROP
# The span attribute to match against.
attribute: url.path
# The pattern to compare the span attribute to.
pattern: /actuator.*
```

`rule_based_routing` sampler can be used anywhere a sampler is used in the configuration model. For example, the following YAML demonstrates a typical configuration, setting `rule_based_routing` sampler as the `root` sampler of `parent_based` sampler. In this configuration:

* The `parent_based` sampler samples based on the sampling status of the parent.
* Or, if there is no parent, delegates to the `rule_based_routing` sampler.
* The `rule_based_routing` sampler drops spans where `kind=SERVER` and `url.full matches .*/actuator.*`, else it samples and records.
jack-berg marked this conversation as resolved.
Show resolved Hide resolved

```yaml
// ... the rest of the configuration file is omitted for brevity
// For more example see: https://github.com/open-telemetry/opentelemetry-configuration/blob/main/README.md#starter-templates
jack-berg marked this conversation as resolved.
Show resolved Hide resolved
tracer_provider:
sampler:
parent_based:
# Configure the parent_based sampler's root sampler to be rule_based_routing sampler.
root:
rule_based_routing:
# Fallback to the always_on sampler if the criteria is not met.
fallback_sampler:
always_on:
# Only apply to SERVER spans.
span_kind: SERVER
rules:
# Drop spans where url.path matches the regex /actuator.* (i.e. spring boot actuator endpoints).
- action: DROP
attribute: url.path
pattern: /actuator.*
```

## Component owners

- [Trask Stalnaker](https://github.com/trask), Microsoft
Expand Down
7 changes: 6 additions & 1 deletion samplers/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,13 @@ otelJava.moduleName.set("io.opentelemetry.contrib.sampler")

dependencies {
api("io.opentelemetry:opentelemetry-sdk")

compileOnly("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi")
compileOnly("io.opentelemetry:opentelemetry-sdk-extension-incubator")

implementation("io.opentelemetry.semconv:opentelemetry-semconv")

testImplementation("io.opentelemetry.semconv:opentelemetry-semconv-incubating")
testImplementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")
api("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi")
testImplementation("io.opentelemetry:opentelemetry-sdk-extension-incubator")
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
/*
* Copyright The OpenTelemetry Authors
* SPDX-License-Identifier: Apache-2.0
*/

package io.opentelemetry.contrib.sampler.internal;

import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.trace.SpanKind;
import io.opentelemetry.contrib.sampler.RuleBasedRoutingSampler;
import io.opentelemetry.contrib.sampler.RuleBasedRoutingSamplerBuilder;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigurationException;
import io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider;
import io.opentelemetry.sdk.autoconfigure.spi.internal.StructuredConfigProperties;
import io.opentelemetry.sdk.extension.incubator.fileconfig.FileConfiguration;
import io.opentelemetry.sdk.trace.samplers.Sampler;
import java.util.List;

/**
* Declarative configuration SPI implementation for {@link RuleBasedRoutingSampler}.
*
* <p>This class is internal and is hence not for public use. Its APIs are unstable and can change
* at any time.
*/
public class RuleBasedRoutingSamplerComponentProvider implements ComponentProvider<Sampler> {

private static final String ACTION_RECORD_AND_SAMPLE = "RECORD_AND_SAMPLE";
private static final String ACTION_DROP = "DROP";

@Override
public Class<Sampler> getType() {
return Sampler.class;
}

@Override
public String getName() {
return "rule_based_routing";
}

@Override
public Sampler create(StructuredConfigProperties config) {
StructuredConfigProperties fallbackModel = config.getStructured("fallback_sampler");
if (fallbackModel == null) {
throw new ConfigurationException(
"rule_based_routing sampler .fallback is required but is null");
}
Sampler fallbackSampler;
try {
fallbackSampler = FileConfiguration.createSampler(fallbackModel);
} catch (ConfigurationException e) {
throw new ConfigurationException(
"rule_Based_routing sampler failed to create .fallback sampler", e);
}

String spanKindString = config.getString("span_kind", "SERVER");
SpanKind spanKind;
try {
spanKind = SpanKind.valueOf(spanKindString);
} catch (IllegalArgumentException e) {
throw new ConfigurationException(
"rule_based_routing sampler .span_kind is invalid: " + spanKindString, e);
}

RuleBasedRoutingSamplerBuilder builder =
RuleBasedRoutingSampler.builder(spanKind, fallbackSampler);

List<StructuredConfigProperties> rules = config.getStructuredList("rules");
if (rules == null || rules.isEmpty()) {
throw new ConfigurationException("rule_based_routing sampler .rules is required");
}

for (StructuredConfigProperties rule : rules) {
String attribute = rule.getString("attribute");
if (attribute == null) {
throw new ConfigurationException(
"rule_based_routing sampler .rules[].attribute is required");
}
AttributeKey<String> attributeKey = AttributeKey.stringKey(attribute);
String pattern = rule.getString("pattern");
if (pattern == null) {
throw new ConfigurationException("rule_based_routing sampler .rules[].pattern is required");
}
String action = rule.getString("action");
if (action == null) {
throw new ConfigurationException("rule_based_routing sampler .rules[].action is required");
}
if (action.equals(ACTION_RECORD_AND_SAMPLE)) {
builder.recordAndSample(attributeKey, pattern);
} else if (action.equals(ACTION_DROP)) {
builder.drop(attributeKey, pattern);
} else {
throw new ConfigurationException(
"rule_based_routing sampler .rules[].action is must be "
+ ACTION_RECORD_AND_SAMPLE
+ " or "
+ ACTION_DROP);
}
}

return builder.build();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
io.opentelemetry.contrib.sampler.internal.RuleBasedRoutingSamplerComponentProvider
Loading
Loading