JMX Metrics: Improved MBean and Instrument helpers #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
requested review from
anuraaga,
pmcollins and
trask
as code owners
rmfitzpatrick
force-pushed
the
default_metrics
branch
3 times, most recently
from
0dd6450
to
2ef6504
Compare
pmcollins
approved these changes
Oct 22, 2020
contrib/jmx-metrics/src/main/java/io/opentelemetry/contrib/jmxmetrics/JmxClient.java
Outdated
Show resolved
Hide resolved
contrib/jmx-metrics/src/main/java/io/opentelemetry/contrib/jmxmetrics/JmxClient.java
Outdated
Show resolved
Hide resolved
| return | ||
| } | ||
|
|
||
| [mbeans, values].transpose().each { mbean, value -> |
contrib/jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/InstrumentHelper.groovy
Outdated
Show resolved
Hide resolved
contrib/jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/MBeanHelper.groovy
Show resolved
Hide resolved
contrib/jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/MBeanHelper.groovy
Outdated
Show resolved
Hide resolved
contrib/jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/MBeanHelper.groovy
Outdated
Show resolved
Hide resolved
contrib/jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/MBeanHelper.groovy
Outdated
Show resolved
Hide resolved
contrib/jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/OtelHelper.groovy
Outdated
Show resolved
Hide resolved
...b/jmx-metrics/src/main/java/io/opentelemetry/contrib/jmxmetrics/GroovyMetricEnvironment.java
Show resolved
Hide resolved
rmfitzpatrick
force-pushed
the
default_metrics
branch
from
2ef6504
to
12d31f3
Compare
rmfitzpatrick
force-pushed
the
default_metrics
branch
from
12d31f3
to
9d95350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Feature addition - Adds new
MBeanHelperandInstrumentHelperutilities so that custom and target Groovy scripts are easier to implement. Also adopts these helpers with included JVM target metrics for more context.Existing Issue(s):
In my opinion, this gets us a bit closer to #5 as the updated
OtelHelperfunctionality will likely mirror the static scripts in some capacity.Testing:
Added unit tests.
Documentation:
Updated readmes.
Outstanding items:
Existing Cassandra target system script should be updated to use this new system.
I also intend to correct the JVM target metric docs shortly as they are partially complete at the moment.(edit: completed)