Pin play smoke test to guice 5 (#12488)

open-telemetry · Oct 22, 2024 · 1621f21 · 1621f21
1 parent 6cbdd01
commit 1621f21
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.github/renovate.json5 b/.github/renovate.json5
@@ -149,6 +149,14 @@
       "matchUpdateTypes": ["major"],
       "enabled": false
     },
+    {
+      // intentionally pinning specifically to guice 5 in the play smoke test
+      // until we are able to test against the latest version of play
+      "matchFileNames": ["smoke-tests/images/play/build.gradle.kts"],
+      "matchPackagePrefixes": ["com.google.inject:", "com.google.inject.extensions:"],
+      "matchUpdateTypes": ["major"],
+      "enabled": false
+    },
     {
       // intentionally aligning both netty 4.0 and 4.1 version in this convention
       "matchFileNames": ["conventions/src/main/kotlin/otel.java-conventions.gradle.kts"],

diff --git a/smoke-tests/images/play/build.gradle.kts b/smoke-tests/images/play/build.gradle.kts
@@ -27,8 +27,8 @@ dependencies {
   implementation("com.typesafe.play:play-guice_$scalaVer:$playVer")
   // Guice 5.1 is needed for Java 17 support on Play 2.8, see https://github.com/playframework/playframework/releases/tag/2.8.15
   // TODO (trask) remove these version overrides after updating to Play 2.9
-  implementation("com.google.inject:guice:7.0.0")
-  implementation("com.google.inject.extensions:guice-assistedinject:7.0.0")
+  implementation("com.google.inject:guice:5.1.0")
+  implementation("com.google.inject.extensions:guice-assistedinject:5.1.0")
   implementation("com.typesafe.play:play-logback_$scalaVer:$playVer")
   implementation("com.typesafe.play:filters-helpers_$scalaVer:$playVer")
 }