stabilise spanNames #12487
Open
stabilise spanNames #12487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steverao
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
It looks good! But I am curious about if there are any other documents or discussions to support this migration apart from quarkusio/quarkus#41521 (comment)? Because I am not sure whether other classes in instrumentation-api-incubator exist similar problem. @trask
trask
reviewed
Oct 22, 2024
| package io.opentelemetry.instrumentation.api.incubator.semconv.util; | ||
| package io.opentelemetry.instrumentation.api.semconv.util; |
There was a problem hiding this comment.
let's keep the old class for a few releases (maybe until 3.0), and mark it deprecated, to give people an easy path forward
trask
reviewed
Oct 22, 2024
| import java.util.Map; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
|
|
||
| @Deprecated |
There was a problem hiding this comment.
let's include a javadoc with a link to the new stable API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve issue
move
SpanNamesfrominstrumentation-api-incubatortoinstrumentation-api