Skip to content

Commit

Permalink
Codify stance against using java-test-fixtures plugin (#6696)
Browse files Browse the repository at this point in the history
  • Loading branch information
jack-berg authored Sep 11, 2024
1 parent 0feca55 commit 8fb169e
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,13 @@ uses [google-java-format](https://github.com/google/google-java-format) library:
synchronized (lock) { ... }
}
```
* Don't
use [gradle test fixtures](https://docs.gradle.org/current/userguide/java_testing.html#sec:java_test_fixtures) (
i.e. `java-test-fixtures` plugin) to reuse code for internal testing. The test fixtures plugin has
side effects where test dependencies are added to the `pom.xml` and publishes an
extra `*-test-fixtures.jar` artifact which is unnecessary for internal testing. Instead, create a
new `*:testing-internal` module and omit the `otel.java-conventions`. For example,
see [/exporters/otlp/testing-internal](./exporters/otlp/testing-internal).
If you notice any practice being applied in the project consistently that isn't listed here, please
consider a pull request to add it.
Expand Down

0 comments on commit 8fb169e

Please sign in to comment.