Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken markdown links #6655

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

SylvainJuge
Copy link
Contributor

Fixes few broken markdown links that prevent jobs from executing properly in CI now that markdown lint has been enabled.

The targeted file was removed in open-telemetry/opentelemetry-specification#4128.

Command to validate (copy-paste from what is executed in CI).

find . -type f \                                                                                                                                                                                                                                                                   git:(fix-broken-links)
         -name '*.md' \
         -not -path './CHANGELOG.md' \
       | xargs .github/scripts/markdown-link-check-with-retry.sh

@SylvainJuge SylvainJuge requested a review from a team August 19, 2024 11:37
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (ad120a5) to head (f7cb38a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6655   +/-   ##
=========================================
  Coverage     90.05%   90.05%           
  Complexity     6275     6275           
=========================================
  Files           697      697           
  Lines         18944    18944           
  Branches       1858     1858           
=========================================
  Hits          17060    17060           
  Misses         1307     1307           
  Partials        577      577           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SylvainJuge
Copy link
Contributor Author

@jack-berg since you opened the related specification PR can I let you review and merge this ? This makes other PRs like #6654 fail in CI due to this.

@jack-berg
Copy link
Member

Thanks for the fix @SylvainJuge!

@jack-berg jack-berg merged commit 023c8cc into open-telemetry:main Aug 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants