Add ByteBuffer field type marshaling support to exporter.

[jhalliday]

The marshaling utility code has not previously needed to support encoding of ByteBuffer type fields, as they are not used by any existing protocol. With the creation of the new experimental profiling signal type, that changes.

#6680 adds support for marshaling the new signal, but converts the ByteBuffer field into byte[] first, which is not ideal. To allow the ByteBuffer to be passed directly to the serialization code, we add support through Serializer and MarshalerUtil. The bulk of the change is in CodedOutputStream, the upstream protobuf version of which has ByteBuffer support already, so this is really just reinstating it in the fork.

In so doing, I've opted to keep the data handling behaviour based on 'buffer capacity, not position/limit' semantics of the protobuf lib for consistency, though that may be seen as running contrary to the intended API usage semantics of ByteBuffer. What we expose at the user API level may or may not be the same - ProfileContainerMarshaler currently uses position/limit instead.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 89.91%. Comparing base (b927d9d) to head (38dcbbf).

Files with missing lines	Patch %	Lines
...y/exporter/internal/marshal/CodedOutputStream.java	0.00%	26 Missing ⚠️
...etry/exporter/internal/marshal/JsonSerializer.java	0.00%	4 Missing ⚠️
...elemetry/exporter/internal/marshal/Serializer.java	0.00%	4 Missing ⚠️
...metry/exporter/internal/marshal/MarshalerUtil.java	0.00%	3 Missing ⚠️
...try/exporter/internal/marshal/ProtoSerializer.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #6686      +/-   ##
============================================
- Coverage     90.10%   89.91%   -0.19%     
  Complexity     6541     6541              
============================================
  Files           728      728              
  Lines         19695    19735      +40     
  Branches       1935     1938       +3     
============================================
- Hits          17746    17745       -1     
- Misses         1349     1389      +40     
- Partials        600      601       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jack-berg]

Let's wait to merge until we can incorporate into #6680 to ensure this works with testing.

[jhalliday]

This is currently deliberately decoupled from the profiling exporter work, though that's clearly its intended use case in the short term. Are you saying you'd like me to bundle in here the code change to profiling that uses this, rather than doing the linkup as a separate change later?
I tested this locally with a simple class that assumes the existing byte[] handling is right and checks that using ByteBuffer instead gives the same results, but felt that was a bit of a hack, so it's not included.

[jack-berg]

Are you saying you'd like me to bundle in here the code change to profiling that uses this, rather than doing the linkup as a separate change later?

Yes, let's wire this into the profile marshaler where we see it being used, since that allows us to get some test coverage.

(Sorry for the delay. I missed your reply.)

[jhalliday]

Not a problem. Done.