Issue #6630: Stabilize ExceptionEventData #6787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
reviewed
Oct 15, 2024
There was a problem hiding this comment.
There are the variety of basic problems with this PR. I'd normally spend time addressing each problem individually, but this looks like the output of an LLM, and so I'm reluctant to spend time on it.
So for now I'll just leave some high level comments:
- Check out the contributing guide
- Follow the example of other code in the repository
- I don't care if you use llms as a starting spot, but a raw copy / paste of the output is rarely going to work, and is an easy way to loose maintainer confidence. After all, why should I spend time / effort with a thoughtful review if the effort isn't reciprocated? Its easier (and more enjoyable) to do the work myself.
|
@jack-berg My apologies for any inconveniences caused, I'll revert the changes made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6630 - Stabilize ExceptionEventData
The class is now well-structured for stability and immutability and It correctly handles input validation and provides a clean interface for accessing its data.
@jack-berg Please kindly review, I'll appreciate your feedback on it and let me know if there's any corrections I can make