setStatus method conforms to the specified behavior regarding status … #6808
+31
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code priorities and description handling Relate to open-telemetry#6797
jack-berg
reviewed
Oct 21, 2024
| this.status = StatusData.create(statusCode, description); | ||
| } | ||
| return this; | ||
| synchronized (lock) { |
There was a problem hiding this comment.
We use spotless to ensure consist code formatting. Please run ./gradlew spotlessApply.
| @@ -418,22 +418,37 @@ private void addTimedEvent(EventData timedEvent) { | |||
|
|
|||
| @Override | |||
| public ReadWriteSpan setStatus(StatusCode statusCode, @Nullable String description) { | |||
| if (statusCode == null) { | |||
| return this; | |||
| } | |||
|
|
||
| // Prevent setting a lower priority status | ||
| if (currentStatusCode == StatusCode.OK) { | ||
| logger.log(Level.FINE, "Calling setStatus() on a Span that is already set to OK."); |
There was a problem hiding this comment.
Only log a warning the target status code is != StatusCode.OK.
| if (statusCode == StatusCode.ERROR) { | ||
| this.status = StatusData.create(statusCode, description); // Allow description for ERROR | ||
| } else { | ||
| this.status = StatusData.create(statusCode, null); // Ignore description for non-ERROR statuses |
There was a problem hiding this comment.
#nit: Let's skip the extra allocation if the status code doesn't stand to change.
Suggested change
| this.status = StatusData.create(statusCode, null); // Ignore description for non-ERROR statuses | |
| if (currentStatusCode != statusCode) { | |
| this.status = StatusData.create(statusCode, null); // Ignore description for non-ERROR statuses | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…code priorities and description handling
Relate to #6797