Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation-runtime-node): use the correct unit for eventloop.utilization #2631

Merged
merged 6 commits into from
Jan 9, 2025
Merged

fix(instrumentation-runtime-node): use the correct unit for eventloop.utilization #2631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cfac2d9
fix unit for eventloop.utilization
maryliag Jan 8, 2025
767ba28
fix unit for eventloop.utilization
maryliag Jan 8, 2025
479500f
Merge branch 'fix-runtime-unit' of github.com:maryliag/opentelemetry-…
maryliag Jan 8, 2025
3f77376
Merge branch 'fix-runtime-unit' of github.com:maryliag/opentelemetry-…
maryliag Jan 8, 2025
b1719b4
Merge branch 'fix-runtime-unit' of github.com:maryliag/opentelemetry-…
maryliag Jan 9, 2025
320f48b
Merge branch 'main' into fix-runtime-unit
pichlermarc Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class EventLoopUtilizationCollector extends BaseCollector {
`${this.namePrefix}.${ATTR_NODEJS_EVENT_LOOP_UTILIZATION}`,
{
description: 'Event loop utilization',
unit: 's',
unit: '1',
}
)
.addCallback(async observableResult => {
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/instrumentation-runtime-node/test/event_loop_utilization.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ describe(`${ConventionalNamePrefix.NodeJs}.${ATTR_NODEJS_EVENT_LOOP_UTILIZATION}

assert.strictEqual(
utilizationMetric!.descriptor.unit,
's',
'1',
'expected default unit'
);

Expand Down
Loading