Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(aws-sdk): drop support for Node.js 14.x [DO NOT MERGE] #2632

Closed
wants to merge 2 commits into from

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Jan 8, 2025

Which problem is this PR solving?

Short description of the changes

  • This PR is just to check if CI fails, if we try to drop support for Node.js 14.x in one of the @opentelemetry/auto-instrumentations-node dependencies

@trivikr trivikr requested a review from a team as a code owner January 8, 2025 20:46
@github-actions github-actions bot requested review from blumamir and jj22ee January 8, 2025 20:47
@trivikr trivikr force-pushed the aws-sdk-drop-node14 branch from c19aefb to 6da889c Compare January 8, 2025 20:47
@trivikr trivikr changed the title [DRAFT] test(aws-sdk): drop support for Node.js 14.x test(aws-sdk): drop support for Node.js 14.x [DO NOT MERGE] Jan 8, 2025
@trivikr trivikr marked this pull request as draft January 8, 2025 20:50
@trivikr
Copy link
Contributor Author

trivikr commented Jan 8, 2025

The CI failures are due to some network connectivity. Converting to CI so that it's not merged.
I'll rebase when new commits are pushed to main, and recheck.

@trivikr trivikr force-pushed the aws-sdk-drop-node14 branch from f31f672 to dfb0af2 Compare January 9, 2025 18:35
@trivikr
Copy link
Contributor Author

trivikr commented Jan 9, 2025

CI succeeds for Node.js 14.x. CI failures for Node.js 16.x seems to be unrelated.
There's no separate CI failure for incorrectly upgrading the engines field.

@trivikr trivikr closed this Jan 9, 2025
@trivikr trivikr deleted the aws-sdk-drop-node14 branch January 9, 2025 19:12
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (3350583) to head (dfb0af2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2632   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         169      169           
  Lines        8059     8059           
  Branches     1645     1645           
=======================================
  Hits         7317     7317           
  Misses        742      742           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants