Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update component ownership guidelines and templates #2641

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Jan 13, 2025

Which problem is this PR solving?

  • Updates the instrumentation request template to include the ownership requirements checklist (makes the process a bit clearer)
  • Adds documentation that we give triage permissions to component owners (refs Add component owners to js-contrib-triagers role #2600)
  • Adds a recommendation that component owners apply the has:owner-approval label upon approval to signal to maintainers that the PR is ready to merge (reducing time to merge and cutting down on pings for maintainers)
  • Clarifies that a separate repo close to the org that maintains the instrumented package is a feasible location for hosting a instrumentation package (reduces time needed to explain this)

@pichlermarc pichlermarc requested a review from a team as a code owner January 13, 2025 13:01
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (6b4e532) to head (7a27fc5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2641   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         169      169           
  Lines        8061     8061           
  Branches     1646     1646           
=======================================
  Hits         7319     7319           
  Misses        742      742           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants