Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detector-aws): remove all deprecation warnings #2642

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

garysassano
Copy link

Which problem is this PR solving?

All experimental attributes were moved to @opentelemetry/semantic-conventions/incubating (see README) and the naming convention was changed, so there are currently dozens of deprecation being displayed for AWS Detectors.

Short description of the changes

This PR updates all attributes for AWS Detectors to the new convention.

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual code changes look good, but the package.json changes I think are not needed in this PR

@garysassano garysassano requested a review from dyladan January 15, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants