Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: feat(instrumentation/asgi): add target to metrics #1436

Closed
wants to merge 2 commits into from

Commits on Nov 10, 2022

  1. revert: feat(instrumentation/asgi): add target to metrics

    Unfortunately I made a mistake in open-telemetry#1323 where I assumed that the scope was laready being processed by the framework at the moment of reporting, but of course that's not true as the framework has not even seen the request at that point.
    
    Is for that reason that we are not able to extract any route information in the middleware to report what the target is.
    
    Sorry for the noise, and be happy to help if anyone has any idea how we could fix this.
    sk- committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    50168db View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Configuration menu
    Copy the full SHA
    e8d6556 View commit details
    Browse the repository at this point in the history