Replies: 7 comments 4 replies
-
No emojies for voting? :) Both have upsides and downsides. Another approach would be to just improve our tooling to make CI faster. I don't think git repo history is a big deal and in fact might be better since people can look at the entire history at once when trying to identify issues. This makes tools like |
Beta Was this translation helpful? Give feedback.
-
FWIW, this was discussed at some length across the OpenTelemetry project. In my opinion, the management of N repos makes this difficult for maintainers as well as users. There are some clear upsides to splitting the packages, but I think some of the concerns around git history for example, can be alleviated by not releasing every package every time which is already being discussed. Additionally CI could be smarter and skip tests for packages that have not changed. |
Beta Was this translation helpful? Give feedback.
-
In fact, I suggest we split in multiple repos all the components of this project, including |
Beta Was this translation helpful? Give feedback.
-
It is possible to add GitHub workflows that trigger depending on the paths touched in a PR. Also consider what happens when you change the API package: Then you somehow need to manually run/trigger a build for all the separate repositories to check if they still work with the changed API. That setup sounds like it heavily discourages changing of depended-upon repositories. As a consequence it becomes easier to copy-paste some utility function around and change the copy than to change the central function, because even if I believe the change to be backwards-compatible, I have no easy way to verify. EDIT: Basically, splitting repos up would be the opposite of "Continous Integration", because now the code is not automatically integrated across repositories. |
Beta Was this translation helpful? Give feedback.
-
Is that a tangible advantage? You can already do |
Beta Was this translation helpful? Give feedback.
-
Well, seems like this idea does not have much support from the rest of the community 🤷 😅 We'll leave the repos as they are now ✌️ |
Beta Was this translation helpful? Give feedback.
-
Sorry to bring this issue back, but I just realized this:
I can imagine it being problematic to have a single contrib repo where lots of people, many of whom could be outside of the current group of regular contributors, have write permissions. This is related to this issue, @NathanielRN. |
Beta Was this translation helpful? Give feedback.
-
This is somewhat related to #1986.
Instead of having single contrib and core repos, I suggest we have a single Github Organization (probably named opentelemetry-python) which holds all the repos.
This is advantageous because:
Ok, adding emojis for voting 😆
If you agree with separating the contrib packages into their own repos: 👍
If you disagree with separating the contrib packages into their own repos: 👎
Beta Was this translation helpful? Give feedback.
All reactions