Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etw-exporter-metrics updates to opentelemetry, better error logging #105

Merged
merged 8 commits into from
Sep 10, 2024

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Sep 9, 2024

Related to #104, just adding better logging. Actual fixes are not part of this PR.
Also upgrades opentelemetry dependencies to latest by hand. Will update workspace in a future PR.

@cijothomas cijothomas requested a review from a team September 9, 2024 20:03
@cijothomas cijothomas changed the title Better error logging for etw-exporter-metrics when etw size limit hits etw-exporter-metrics updates to opentelemetry, better error logging Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 56.4%. Comparing base (56a6f45) to head (683e8bb).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-etw-metrics/src/exporter/mod.rs 0.0% 16 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #105     +/-   ##
=======================================
+ Coverage   52.3%   56.4%   +4.1%     
=======================================
  Files         38      39      +1     
  Lines       4967    5445    +478     
=======================================
+ Hits        2598    3072    +474     
- Misses      2369    2373      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 68a534c into open-telemetry:main Sep 10, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants