Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate proto files in opentelemetry-stackdriver. #108

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

fiadliel
Copy link
Contributor

Changes

#102 updated proto files, but they've diverged again.
Probably these should remain #[ignore]d. Maybe run a separate (scheduled?) build check for them?

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.4%. Comparing base (56a6f45) to head (440a2cd).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-stackdriver/src/proto/api.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #108     +/-   ##
=======================================
+ Coverage   52.3%   56.4%   +4.1%     
=======================================
  Files         38      39      +1     
  Lines       4967    5446    +479     
=======================================
+ Hits        2598    3072    +474     
- Misses      2369    2374      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member

lalitb commented Sep 10, 2024

Probably these should remain #[ignore]d. Maybe run a separate (scheduled?) build check for them?

I think [ignore]d would hide any required proto changes. But if this happens too often, we may have to revisit again.

@lalitb lalitb merged commit 823f970 into open-telemetry:main Sep 10, 2024
8 of 9 checks passed
@fiadliel fiadliel deleted the update_generated_protobufs branch September 10, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants