Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release (with bump to otel-rust v0.25) #109

Merged
merged 8 commits into from
Sep 17, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Sep 10, 2024

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 31.30435% with 79 lines in your changes missing coverage. Please review.

Project coverage is 56.4%. Comparing base (56a6f45) to head (f17da43).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-etw-logs/src/logs/exporter.rs 15.9% 37 Missing ⚠️
...pentelemetry-user-events-logs/src/logs/exporter.rs 0.0% 36 Missing ⚠️
...ser-events-logs/src/logs/reentrant_logprocessor.rs 0.0% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #109     +/-   ##
=======================================
+ Coverage   52.3%   56.4%   +4.1%     
=======================================
  Files         38      39      +1     
  Lines       4967    5444    +477     
=======================================
+ Hits        2598    3072    +474     
- Misses      2369    2372      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb marked this pull request as ready for review September 10, 2024 08:33
@lalitb lalitb requested a review from a team September 10, 2024 08:33
@cijothomas cijothomas merged commit 281c215 into open-telemetry:main Sep 17, 2024
8 of 9 checks passed
@cijothomas
Copy link
Member

@lalitb let me know if you are doing the release for the crates from this repo.
(for next time, we can steal/clone the script from main repo here too)

@lakaniemi
Copy link

@lalitb for opentelemetry-datadog, the cargo.toml file does not use workspace = true for the dependencies:

opentelemetry = { version = "0.24", features = ["trace"] }
opentelemetry_sdk = { version = "0.24", features = ["trace"] }
opentelemetry-http = { version = "0.13" }

Doesn't that mean that the datadog package is not updated properly to the newest versions?

@lalitb
Copy link
Member Author

lalitb commented Sep 18, 2024

@lalitb let me know if you are doing the release for the crates from this repo. (for next time, we can steal/clone the script from main repo here too)

Yes i will do the release.

@lalitb
Copy link
Member Author

lalitb commented Sep 18, 2024

@lalitb for opentelemetry-datadog, the cargo.toml file does not use workspace = true for the dependencies:

opentelemetry = { version = "0.24", features = ["trace"] }
opentelemetry_sdk = { version = "0.24", features = ["trace"] }
opentelemetry-http = { version = "0.13" }

Doesn't that mean that the datadog package is not updated properly to the newest versions?

Yes @lakaniemi , its not in this release. Will look into it separately, i believe it had some issue.

@tsfotis
Copy link

tsfotis commented Sep 23, 2024

@lalitb When will these be released to crates.io?

@lalitb
Copy link
Member Author

lalitb commented Sep 23, 2024

@lalitb When will these be released to crates.io?

Sorry have been travelling. Will do it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants