Datadog Source Code Integration #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=====================================
Coverage 40.4% 40.4%
=====================================
Files 12 12
Lines 1277 1277
=====================================
Hits 516 516
Misses 761 761 ☔ View full report in Codecov by Sentry. |
lalitb
approved these changes
Dec 17, 2023
TommyCpp
reviewed
Dec 18, 2023
| @@ -188,10 +188,13 @@ where | |||
| _ => 0, | |||
| }, | |||
| )?; | |||
|
|
|||
| const GIT_META_TAGS_COUNT: u32 = if matches!((option_env!("DD_GIT_REPOSITORY_URL"), option_env!("DD_GIT_COMMIT_SHA")), (Some(_), Some(_))) { 2 } else { 0 }; | |||
There was a problem hiding this comment.
nit: can we move this to top of the file with other constant?
hdost
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request introduces part of Datadog Source Code Integration
Added compile time env variables:
DD_GIT_REPOSITORY_URLandDD_GIT_COMMIT_SHA. Exporter will send this information in sampled traces.Example of usage