Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentelemetry-stackdriver: Update Stackdriver schema #61

Closed
wants to merge 3 commits into from
Closed

opentelemetry-stackdriver: Update Stackdriver schema #61

wants to merge 3 commits into from

Conversation

hdost
Copy link
Contributor

@hdost hdost commented Apr 21, 2024

This will fix CI.

  • Add versioning field.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@hdost
opentelemetry-stackdriver: Update Stackdriver schema
f2f9b3e 
This will fix CI.

- Add versioning field.
@hdost hdost requested a review from a team April 21, 2024 18:01
TommyCpp
TommyCpp reviewed Apr 21, 2024
View reviewed changes
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I still see the version mismatch in CI?

@lalitb
Copy link
Member

lalitb commented May 15, 2024 •
edited
Loading

Have removed the stackdriver from the root workspace for now as it's build is failing. We can bring it back once fixed.

@lalitb
Copy link
Member

lalitb commented May 24, 2024

The CI is not failing anymore without this PR. Are changes still relevant?
@hdost @djc if anyone knows.

@djc
Copy link
Contributor

djc commented May 24, 2024

I don't think this is necessary.

@lalitb
Copy link
Member

lalitb commented May 24, 2024

Not relevant anymore.

@lalitb lalitb closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TommyCpp TommyCpp TommyCpp left review comments

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hdost @lalitb @djc @cijothomas @TommyCpp