Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collector config: don't link to deprecated ServiceTelemetryMetrics struct #3514

Closed
chalin opened this issue Nov 8, 2023 · 3 comments
Closed

Comments

@chalin
Copy link
Contributor

chalin commented Nov 8, 2023

Originally posted by @chalin in #3443 (comment)

As I mentioned in the other PR making changes to this section, I don't think we should be linking out to the source file. Especially because that config file has been deprecated!

We should just list the "full options" (there aren't that many) here.


If you choose to keep the link for now, I'd at least suggest the following rewording to avoid a "here" link:

for scraping at <http://localhost:8888/metrics>. For the full list of options
for the `metrics` subsection, see the 
[`ServiceTelemetryMetrics struct`](https://github.com/open-telemetry/opentelemetry-collector/blob/7666eb04c30e5cfd750db9969fe507562598f0ae/config/service.go#L99-L111) comments.

References

This is the link info the config file:

/cc @open-telemetry/collector-approvers @theletterf

@tiffany76
Copy link
Contributor

I think we can close this issue. The link in question was removed in #4504.

@svrnm
Copy link
Member

svrnm commented Jun 3, 2024

@chalin PTAL for closing this

@chalin
Copy link
Contributor Author

chalin commented Jun 3, 2024

Thanks, I'll take @tiffany76's word for it.

@chalin chalin closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants