Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blog post] Introduce new OTel features in Envoy and Istio #4553

Merged
merged 31 commits into from
Jun 7, 2024

Conversation

joaopgrassi
Copy link
Member

@joaopgrassi joaopgrassi commented May 28, 2024

@joaopgrassi joaopgrassi requested review from a team May 28, 2024 11:45
@joaopgrassi
Copy link
Member Author

CC @jsuereth

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small copy edit suggestions. The docs maintainers might have more to say. Thanks!

Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
@joaopgrassi
Copy link
Member Author

I merged main, and fix:format is changing format on a lot of files, but here CI only complains about my file. Is there anything that I'm missing locally after merging main into my branch? 🤔

@svrnm
Copy link
Member

svrnm commented Jun 4, 2024

I merged main, and fix:format is changing format on a lot of files, but here CI only complains about my file. Is there anything that I'm missing locally after merging main into my branch? 🤔

We updated some of our tooling just yesterday, might be the case that something slipped here, cc @chalin

@svrnm
Copy link
Member

svrnm commented Jun 4, 2024

We just published another blog post, so let's give it another 2 days and then we can merge this one in.

joaopgrassi and others added 3 commits June 5, 2024 10:33
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@joaopgrassi
Copy link
Member Author

We updated some of our tooling just yesterday, might be the case that something slipped here, cc @chalin

Ah I see, it was because I didn't npm install. Now it works!

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well written post @joaopgrassi! 🙌🏻 I enjoyed reading it.

I made another copyedit pass, see inline comments.

@chalin
Copy link
Contributor

chalin commented Jun 5, 2024

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9383659493

@opentelemetrybot
Copy link
Collaborator

fix:refcache run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/9383659493 for details

@chalin
Copy link
Contributor

chalin commented Jun 5, 2024

Not sure why it's failing. /cc @svrnm
We may have to do this one manually (I don't have time atm, if someone else wants to give it a try.)

@joaopgrassi
Copy link
Member Author

We may have to do this one manually (I don't have time atm, if someone else wants to give it a try.)

Seems to have been fixed, I did it manually. :)

@chalin
Copy link
Contributor

chalin commented Jun 5, 2024

Ah, it seems to have failed because you pushed a commit before it was able to. I'm glad that it's all fixed.

@svrnm - this seems ready to merge. If it lands today, we'll need to adjust the date.

@svrnm svrnm merged commit 8b2f450 into open-telemetry:main Jun 7, 2024
15 checks passed
@svrnm
Copy link
Member

svrnm commented Jun 7, 2024

https://opentelemetry.io/blog/2024/new-otel-features-envoy-istio/ 🎉

ymotongpoo pushed a commit to ymotongpoo/opentelemetry.io that referenced this pull request Jun 8, 2024
@joaopgrassi joaopgrassi deleted the blog-envoy-istio branch June 10, 2024 08:44
@joaopgrassi
Copy link
Member Author

Thanks for all the help everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Blog Post: Observability on the Edge: Enhancing OTel support in Envoy and Istio
5 participants