Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Propose way to associate translations to specific commit of default lang page #4582

Closed
5 tasks done
Tracked by #4082 ...
chalin opened this issue Jun 3, 2024 · 2 comments
Closed
5 tasks done
Tracked by #4082 ...
Assignees
Labels
e0-minutes Effort: < 60 min e1-hours Effort: < 8 hrs i18n internationalization p1-high

Comments

@chalin
Copy link
Contributor

chalin commented Jun 3, 2024

Our support for translations is nascent. We have an opportunity to get it right, or at least good enough, from the start.

Let me put something together to show you what I have in mind. In the meantime, I'd suggest delaying the merge of other zh page translations.

Tasks

Related

@chalin chalin added e0-minutes Effort: < 60 min e1-hours Effort: < 8 hrs p1-high i18n internationalization labels Jun 3, 2024
@chalin chalin self-assigned this Jun 3, 2024
@chalin
Copy link
Contributor Author

chalin commented Jun 3, 2024

@open-telemetry/docs-maintainers - FYI, during today's Comms meeting we agreed to not / no longer merge non-en language pages containing embedded en-source page fragments as HTML comments. @svrnm - I assume that you'll follow up with the zh PRs that you merged before the meeting to ask them to strip the comments? Thanks!

@chalin
Copy link
Contributor Author

chalin commented Jun 14, 2024

I'm satsified with the proposed design and implementation, as documented in https://opentelemetry.io/docs/contributing/localization/. We'll continue to vet the approach and adjust as needed, but I'm closing-as-completed for now.

@chalin chalin closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e0-minutes Effort: < 60 min e1-hours Effort: < 8 hrs i18n internationalization p1-high
Projects
None yet
Development

No branches or pull requests

1 participant