Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Localize index page #4580

Merged
merged 6 commits into from
Jun 5, 2024
Merged

[ja] Localize index page #4580

merged 6 commits into from
Jun 5, 2024

Conversation

ymotongpoo
Copy link
Contributor

@ymotongpoo ymotongpoo commented Jun 3, 2024

Docs PR Checklist

  • This PR is for a documentation page whose authoritative copy is in the
    opentelemetry.io repository.

Preview: https://deploy-preview-4580--opentelemetry.netlify.app/ja/

@ymotongpoo ymotongpoo requested a review from a team June 3, 2024 07:49
@svrnm
Copy link
Member

svrnm commented Jun 3, 2024

Thanks @ymotongpoo, can you ask someone who is also a native Japanese speaker to provide a review?

@chalin does this PR everything you need to add Japanese as a language to the website?

@ymotongpoo
Copy link
Contributor Author

@shirou @katzchang can either of you review the JA translation? The volume is pretty small.

content/ja/_index.md Outdated Show resolved Hide resolved
content/ja/_index.md Outdated Show resolved Hide resolved
content/ja/_index.md Outdated Show resolved Hide resolved
@svrnm svrnm added the lang:ja label Jun 4, 2024
@chalin chalin mentioned this pull request Jun 4, 2024
7 tasks
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

As I mentioned during the Comms meeting yesterday, I'll get to this as soon as I can. There's an i18n feature I may want to put into place first.

That being said, there are rebase conflicts. Please rebase and force push and I'll take a look after. I tried rebasing myself, but I'm not qualified to resolve the merge conflicts because I don't understand Japanese 😄.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I still can't rebase, I have made all the necessary fixes. For a preview, see https://deploy-preview-4580--opentelemetry.netlify.app/ja/

IMHO, this is good to merge.

hugo.yaml Outdated
Comment on lines 20 to 21
# params:
# description:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a Japanese translation of "The OpenTelemetry Project Site" to put in these lines. No rush, it can be handled in a followup PR.

@ymotongpoo
Copy link
Contributor Author

@chalin Thank you for your review and I rebased and force pushed my branch to resolve conflicts. I also added metadata in Hugo config for Japanese pages.

@svrnm svrnm merged commit 902043d into open-telemetry:main Jun 5, 2024
15 checks passed
@svrnm
Copy link
Member

svrnm commented Jun 5, 2024

https://opentelemetry.io/ja/ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants