avoid ch creation

open-telemetry · May 31, 2024 · 2634c49 · 2634c49
1 parent ac48602
commit 2634c49
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/collector/processor/concurrentbatchprocessor/batch_processor.go b/collector/processor/concurrentbatchprocessor/batch_processor.go
@@ -441,26 +441,28 @@ func (bp *batchProcessor) countRelease(bytes int64) {
 }
 
 func (b *shard) consumeAndWait(ctx context.Context, data any) error {
-	respCh := make(chan error, 1)
-	item := dataItem{
-		parentCtx:  ctx,
-		data:       data,
-		responseCh: respCh,
-	}
 
+	var itemCount int
 	switch telem := data.(type) {
 	case ptrace.Traces:
-		item.count = telem.SpanCount()
+		itemCount = telem.SpanCount()
 	case pmetric.Metrics:
-		item.count = telem.DataPointCount()
+		itemCount = telem.DataPointCount()
 	case plog.Logs:
-		item.count = telem.LogRecordCount()
+		itemCount = telem.LogRecordCount()
 	}
 
-	if item.count == 0 {
+	if itemCount == 0 {
 		return nil
 	}
 
+	respCh := make(chan error, 1)
+	item := dataItem{
+		parentCtx:  ctx,
+		data:       data,
+		responseCh: respCh,
+		count:      itemCount,
+	}
 	bytes := int64(b.batch.sizeBytes(data))
 
 	if bytes > b.processor.limitBytes {