Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable race detection in make test #207

Closed
wants to merge 8 commits into from
Closed

Enable race detection in make test #207

wants to merge 8 commits into from

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented May 31, 2024 •
edited
Loading

Fixes #206

@jmacd jmacd mentioned this pull request May 31, 2024
Closed
@jmacd
Copy link
Contributor Author

jmacd commented May 31, 2024

I haven't fixed all the races :)

@jmacd jmacd changed the title Avoid test races [concurrentbatch] skip size=0 requests, fix test races May 31, 2024
@jmacd jmacd changed the title [concurrentbatch] skip size=0 requests, fix test races Enable race detection in make test May 31, 2024
@jmacd jmacd marked this pull request as draft May 31, 2024 20:40
@jmacd
Copy link
Contributor Author

jmacd commented Jun 5, 2024

Will close this because it has a messy history. The issue in #214 has to be fixed before we could easily enabled CI/CD race detection.

@jmacd jmacd closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinapathak kristinapathak kristinapathak approved these changes

@mwear mwear mwear approved these changes

@lquerel lquerel lquerel approved these changes

@moh-osman3 moh-osman3 Awaiting requested review from moh-osman3 moh-osman3 is a code owner

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concurrent batch processor: test flake / races
4 participants
@jmacd @lquerel @mwear @kristinapathak