Skip to content

Commit

Permalink
[chore] Move heroku attributes to the registry (#871)
Browse files Browse the repository at this point in the history
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
  • Loading branch information
joaopgrassi and arminru authored Apr 5, 2024
1 parent 98bed07 commit 48892b8
Show file tree
Hide file tree
Showing 8 changed files with 49 additions and 22 deletions.
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ body:
- area:gcp-cloud-run
- area:gcp-gce
- area:graphql
- area:heroku
- area:host
- area:http
- area:k8s
Expand Down
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/change_proposal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ body:
- area:gcp-cloud-run
- area:gcp-gce
- area:graphql
- area:heroku
- area:host
- area:http
- area:k8s
Expand Down
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/new-conventions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ body:
- area:gcp-cloud-run
- area:gcp-gce
- area:graphql
- area:heroku
- area:host
- area:http
- area:k8s
Expand Down
1 change: 1 addition & 0 deletions docs/attributes-registry/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ Currently, the following namespaces exist:
* [Google Cloud Run](gcp-cloud-run.md)
* [Google Compute Engine](gcp-gce.md)
* [GraphQl](graphql.md)
* [Heroku](heroku.md)
* [Host](host.md)
* [HTTP](http.md)
* [K8s](k8s.md)
Expand Down
14 changes: 14 additions & 0 deletions docs/attributes-registry/heroku.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<!--- Hugo front matter used to generate the website version of this page:
--->

# Heroku

## Heroku Attributes

<!-- semconv registry.heroku(omit_requirement_level) -->
| Attribute | Type | Description | Examples | Stability |
|---|---|---|---|---|
| `heroku.app.id` | string | Unique identifier for the application | `2daa2797-e42b-4624-9322-ec3f968df4da` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| `heroku.release.commit` | string | Commit hash for the current release | `e6134959463efd8966b20e75b913cafe3f5ec` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| `heroku.release.creation_timestamp` | string | Time and date the release was created | `2022-10-23T18:00:42Z` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
<!-- endsemconv -->
6 changes: 3 additions & 3 deletions docs/resource/cloud-provider/heroku.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
<!-- semconv heroku -->
| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
|---|---|---|---|---|---|
| `heroku.app.id` | string | Unique identifier for the application | `2daa2797-e42b-4624-9322-ec3f968df4da` | `Opt-In` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| `heroku.release.commit` | string | Commit hash for the current release | `e6134959463efd8966b20e75b913cafe3f5ec` | `Opt-In` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| `heroku.release.creation_timestamp` | string | Time and date the release was created | `2022-10-23T18:00:42Z` | `Opt-In` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| [`heroku.app.id`](../../attributes-registry/heroku.md) | string | Unique identifier for the application | `2daa2797-e42b-4624-9322-ec3f968df4da` | `Opt-In` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| [`heroku.release.commit`](../../attributes-registry/heroku.md) | string | Commit hash for the current release | `e6134959463efd8966b20e75b913cafe3f5ec` | `Opt-In` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| [`heroku.release.creation_timestamp`](../../attributes-registry/heroku.md) | string | Time and date the release was created | `2022-10-23T18:00:42Z` | `Opt-In` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
<!-- endsemconv -->

**Mapping:**
Expand Down
25 changes: 25 additions & 0 deletions model/registry/heroku.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
groups:
- id: registry.heroku
prefix: heroku
type: attribute_group
brief: >
This document defines attributes for the Android platform on which the Android application is running.
attributes:
- id: release.creation_timestamp
type: string
stability: experimental
brief: >
Time and date the release was created
examples: [ '2022-10-23T18:00:42Z' ]
- id: release.commit
type: string
stability: experimental
brief: >
Commit hash for the current release
examples: [ 'e6134959463efd8966b20e75b913cafe3f5ec' ]
- id: app.id
type: string
stability: experimental
brief: >
Unique identifier for the application
examples: [ '2daa2797-e42b-4624-9322-ec3f968df4da' ]
22 changes: 3 additions & 19 deletions model/resource/cloud_provider/heroku.yaml
Original file line number Diff line number Diff line change
@@ -1,28 +1,12 @@
groups:
- id: heroku
prefix: heroku
type: resource
brief: >
Heroku dyno metadata
attributes:
- id: release.creation_timestamp
type: string
stability: experimental
brief: >
Time and date the release was created
examples: [ '2022-10-23T18:00:42Z' ]
- ref: heroku.release.creation_timestamp
requirement_level: opt_in
- id: release.commit
type: string
stability: experimental
brief: >
Commit hash for the current release
examples: [ 'e6134959463efd8966b20e75b913cafe3f5ec' ]
- ref: heroku.release.commit
requirement_level: opt_in
- id: app.id
type: string
stability: experimental
brief: >
Unique identifier for the application
examples: [ '2daa2797-e42b-4624-9322-ec3f968df4da' ]
- ref: heroku.app.id
requirement_level: opt_in

0 comments on commit 48892b8

Please sign in to comment.