Skip to content

Commit

Permalink
[chore] Add registry prefix to registry namespaces that missing it (#851
Browse files Browse the repository at this point in the history
)
  • Loading branch information
trisch-me authored Apr 3, 2024
1 parent be971ee commit fdb088c
Show file tree
Hide file tree
Showing 14 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion docs/attributes-registry/client.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ connection (an exception is made for peer-to-peer communication over TCP where t
protocol / API does not expose a clear notion of client and server).
This also covers UDP network interactions where one side initiates the interaction, e.g. QUIC (HTTP/3) and DNS.

<!-- semconv client(omit_requirement_level) -->
<!-- semconv registry.client(omit_requirement_level) -->
| Attribute | Type | Description | Examples | Stability |
|---|---|---|---|---|
| `client.address` | string | Client address - domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `client.example.com`; `10.1.2.80`; `/tmp/my.sock` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
Expand Down
2 changes: 1 addition & 1 deletion docs/attributes-registry/destination.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ there was a connection or which side initiated it.
This also covers unidirectional UDP flows and peer-to-peer communication where the
"user-facing" surface of the protocol / API does not expose a clear notion of client and server.

<!-- semconv destination(omit_requirement_level) -->
<!-- semconv registry.destination(omit_requirement_level) -->
| Attribute | Type | Description | Examples | Stability |
|---|---|---|---|---|
| `destination.address` | string | Destination address - domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `destination.example.com`; `10.1.2.80`; `/tmp/my.sock` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
Expand Down
2 changes: 1 addition & 1 deletion docs/attributes-registry/server.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ connection (an exception is made for peer-to-peer communication over TCP where t
protocol / API does not expose a clear notion of client and server).
This also covers UDP network interactions where one side initiates the interaction, e.g. QUIC (HTTP/3) and DNS.

<!-- semconv server(omit_requirement_level) -->
<!-- semconv registry.server(omit_requirement_level) -->
| Attribute | Type | Description | Examples | Stability |
|---|---|---|---|---|
| `server.address` | string | Server domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `example.com`; `10.1.2.80`; `/tmp/my.sock` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
Expand Down
2 changes: 1 addition & 1 deletion docs/attributes-registry/source.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ there was a connection or which side initiated it.
This also covers unidirectional UDP flows and peer-to-peer communication where the
"user-facing" surface of the protocol / API does not expose a clear notion of client and server.

<!-- semconv source(omit_requirement_level) -->
<!-- semconv registry.source(omit_requirement_level) -->
| Attribute | Type | Description | Examples | Stability |
|---|---|---|---|---|
| `source.address` | string | Source address - domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `source.example.com`; `10.1.2.80`; `/tmp/my.sock` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
Expand Down
8 changes: 4 additions & 4 deletions docs/general/attributes.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ identify the transport, then setting [`network.transport`](#other-network-attrib
Once the HTTP semantic conventions are declared stable, changes to the attributes in this section will only be allowed
if they do not cause breaking changes to HTTP semantic conventions.

<!-- semconv general.server -->
<!-- semconv server -->
| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
|---|---|---|---|---|---|
| [`server.address`](../attributes-registry/server.md) | string | Server domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `example.com`; `10.1.2.80`; `/tmp/my.sock` | `Recommended` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
Expand Down Expand Up @@ -103,7 +103,7 @@ For Unix domain socket, `server.address` attribute represents remote endpoint ad
Once the HTTP semantic conventions are declared stable, changes to the attributes in this section will only be allowed
if they do not cause breaking changes to HTTP semantic conventions.

<!-- semconv general.client -->
<!-- semconv client -->
| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
|---|---|---|---|---|---|
| [`client.address`](../attributes-registry/client.md) | string | Client address - domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `client.example.com`; `10.1.2.80`; `/tmp/my.sock` | `Recommended` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
Expand All @@ -125,7 +125,7 @@ This also covers unidirectional UDP flows and peer-to-peer communication where t

#### Source

<!-- semconv general.source -->
<!-- semconv source -->
| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
|---|---|---|---|---|---|
| [`source.address`](../attributes-registry/source.md) | string | Source address - domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `source.example.com`; `10.1.2.80`; `/tmp/my.sock` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
Expand All @@ -138,7 +138,7 @@ This also covers unidirectional UDP flows and peer-to-peer communication where t

Destination fields capture details about the receiver of a network exchange/packet.

<!-- semconv general.destination -->
<!-- semconv destination -->
| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
|---|---|---|---|---|---|
| [`destination.address`](../attributes-registry/destination.md) | string | Destination address - domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `destination.example.com`; `10.1.2.80`; `/tmp/my.sock` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
Expand Down
8 changes: 4 additions & 4 deletions model/general.yaml
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
groups:
- id: general.client
- id: client
type: attribute_group
brief: >
General client attributes.
attributes:
- ref: client.address
- ref: client.port
- id: general.server
- id: server
type: attribute_group
brief: >
General server attributes.
attributes:
- ref: server.address
- ref: server.port
- id: general.source
- id: source
type: attribute_group
brief: >
General source attributes.
attributes:
- ref: source.address
- ref: source.port
- id: general.destination
- id: destination
type: attribute_group
brief: >
General destination attributes.
Expand Down
2 changes: 1 addition & 1 deletion model/registry/browser.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
groups:
- id: registry.browser
prefix: browser
type: resource
type: attribute_group
brief: >
The web browser attributes
attributes:
Expand Down
2 changes: 1 addition & 1 deletion model/registry/client.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
groups:
- id: client
- id: registry.client
prefix: client
type: attribute_group
brief: >
Expand Down
2 changes: 1 addition & 1 deletion model/registry/code.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
groups:
- id: registry.code
prefix: code
type: span
type: attribute_group
brief: >
These attributes allow to report this unit of code and therefore to provide more context about the span.
attributes:
Expand Down
2 changes: 1 addition & 1 deletion model/registry/destination.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
groups:
- id: destination
- id: registry.destination
prefix: destination
type: attribute_group
brief: >
Expand Down
2 changes: 1 addition & 1 deletion model/registry/k8s.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
groups:
- id: registry.k8s
prefix: k8s
type: resource
type: attribute_group
brief: >
Kubernetes resource attributes.
attributes:
Expand Down
2 changes: 1 addition & 1 deletion model/registry/server.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
groups:
- id: server
- id: registry.server
prefix: server
type: attribute_group
brief: >
Expand Down
2 changes: 1 addition & 1 deletion model/registry/source.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
groups:
- id: source
- id: registry.source
prefix: source
type: attribute_group
brief: >
Expand Down
2 changes: 1 addition & 1 deletion model/registry/thread.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
groups:
- id: registry.thread
prefix: thread
type: span
type: attribute_group
brief: >
These attributes may be used for any operation to store information about a thread that started a span.
attributes:
Expand Down

0 comments on commit fdb088c

Please sign in to comment.