From fdb088cfa996387836e11bfabb85e585a8693742 Mon Sep 17 00:00:00 2001 From: Alexandra Konrad <10500694+trisch-me@users.noreply.github.com> Date: Wed, 3 Apr 2024 13:58:09 +0200 Subject: [PATCH] [chore] Add registry prefix to registry namespaces that missing it (#851) --- docs/attributes-registry/client.md | 2 +- docs/attributes-registry/destination.md | 2 +- docs/attributes-registry/server.md | 2 +- docs/attributes-registry/source.md | 2 +- docs/general/attributes.md | 8 ++++---- model/general.yaml | 8 ++++---- model/registry/browser.yaml | 2 +- model/registry/client.yaml | 2 +- model/registry/code.yaml | 2 +- model/registry/destination.yaml | 2 +- model/registry/k8s.yaml | 2 +- model/registry/server.yaml | 2 +- model/registry/source.yaml | 2 +- model/registry/thread.yaml | 2 +- 14 files changed, 20 insertions(+), 20 deletions(-) diff --git a/docs/attributes-registry/client.md b/docs/attributes-registry/client.md index e5ad30b661..f09e3b672b 100644 --- a/docs/attributes-registry/client.md +++ b/docs/attributes-registry/client.md @@ -11,7 +11,7 @@ connection (an exception is made for peer-to-peer communication over TCP where t protocol / API does not expose a clear notion of client and server). This also covers UDP network interactions where one side initiates the interaction, e.g. QUIC (HTTP/3) and DNS. - + | Attribute | Type | Description | Examples | Stability | |---|---|---|---|---| | `client.address` | string | Client address - domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `client.example.com`; `10.1.2.80`; `/tmp/my.sock` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) | diff --git a/docs/attributes-registry/destination.md b/docs/attributes-registry/destination.md index 1e5d7339d5..b20874d107 100644 --- a/docs/attributes-registry/destination.md +++ b/docs/attributes-registry/destination.md @@ -11,7 +11,7 @@ there was a connection or which side initiated it. This also covers unidirectional UDP flows and peer-to-peer communication where the "user-facing" surface of the protocol / API does not expose a clear notion of client and server. - + | Attribute | Type | Description | Examples | Stability | |---|---|---|---|---| | `destination.address` | string | Destination address - domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `destination.example.com`; `10.1.2.80`; `/tmp/my.sock` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | diff --git a/docs/attributes-registry/server.md b/docs/attributes-registry/server.md index a55453f54a..f455e8611e 100644 --- a/docs/attributes-registry/server.md +++ b/docs/attributes-registry/server.md @@ -11,7 +11,7 @@ connection (an exception is made for peer-to-peer communication over TCP where t protocol / API does not expose a clear notion of client and server). This also covers UDP network interactions where one side initiates the interaction, e.g. QUIC (HTTP/3) and DNS. - + | Attribute | Type | Description | Examples | Stability | |---|---|---|---|---| | `server.address` | string | Server domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `example.com`; `10.1.2.80`; `/tmp/my.sock` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) | diff --git a/docs/attributes-registry/source.md b/docs/attributes-registry/source.md index b4d4af5da1..d16285965f 100644 --- a/docs/attributes-registry/source.md +++ b/docs/attributes-registry/source.md @@ -11,7 +11,7 @@ there was a connection or which side initiated it. This also covers unidirectional UDP flows and peer-to-peer communication where the "user-facing" surface of the protocol / API does not expose a clear notion of client and server. - + | Attribute | Type | Description | Examples | Stability | |---|---|---|---|---| | `source.address` | string | Source address - domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `source.example.com`; `10.1.2.80`; `/tmp/my.sock` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | diff --git a/docs/general/attributes.md b/docs/general/attributes.md index 5db478df4e..f0df39d9c8 100644 --- a/docs/general/attributes.md +++ b/docs/general/attributes.md @@ -66,7 +66,7 @@ identify the transport, then setting [`network.transport`](#other-network-attrib Once the HTTP semantic conventions are declared stable, changes to the attributes in this section will only be allowed if they do not cause breaking changes to HTTP semantic conventions. - + | Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability | |---|---|---|---|---|---| | [`server.address`](../attributes-registry/server.md) | string | Server domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `example.com`; `10.1.2.80`; `/tmp/my.sock` | `Recommended` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) | @@ -103,7 +103,7 @@ For Unix domain socket, `server.address` attribute represents remote endpoint ad Once the HTTP semantic conventions are declared stable, changes to the attributes in this section will only be allowed if they do not cause breaking changes to HTTP semantic conventions. - + | Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability | |---|---|---|---|---|---| | [`client.address`](../attributes-registry/client.md) | string | Client address - domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `client.example.com`; `10.1.2.80`; `/tmp/my.sock` | `Recommended` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) | @@ -125,7 +125,7 @@ This also covers unidirectional UDP flows and peer-to-peer communication where t #### Source - + | Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability | |---|---|---|---|---|---| | [`source.address`](../attributes-registry/source.md) | string | Source address - domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `source.example.com`; `10.1.2.80`; `/tmp/my.sock` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | @@ -138,7 +138,7 @@ This also covers unidirectional UDP flows and peer-to-peer communication where t Destination fields capture details about the receiver of a network exchange/packet. - + | Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability | |---|---|---|---|---|---| | [`destination.address`](../attributes-registry/destination.md) | string | Destination address - domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `destination.example.com`; `10.1.2.80`; `/tmp/my.sock` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | diff --git a/model/general.yaml b/model/general.yaml index 88693dd442..26df3efc1a 100644 --- a/model/general.yaml +++ b/model/general.yaml @@ -1,26 +1,26 @@ groups: - - id: general.client + - id: client type: attribute_group brief: > General client attributes. attributes: - ref: client.address - ref: client.port - - id: general.server + - id: server type: attribute_group brief: > General server attributes. attributes: - ref: server.address - ref: server.port - - id: general.source + - id: source type: attribute_group brief: > General source attributes. attributes: - ref: source.address - ref: source.port - - id: general.destination + - id: destination type: attribute_group brief: > General destination attributes. diff --git a/model/registry/browser.yaml b/model/registry/browser.yaml index 286c95b193..fad84c9787 100644 --- a/model/registry/browser.yaml +++ b/model/registry/browser.yaml @@ -1,7 +1,7 @@ groups: - id: registry.browser prefix: browser - type: resource + type: attribute_group brief: > The web browser attributes attributes: diff --git a/model/registry/client.yaml b/model/registry/client.yaml index bd214a1708..3b17ed8b4e 100644 --- a/model/registry/client.yaml +++ b/model/registry/client.yaml @@ -1,5 +1,5 @@ groups: - - id: client + - id: registry.client prefix: client type: attribute_group brief: > diff --git a/model/registry/code.yaml b/model/registry/code.yaml index 5848b4fa60..967607205a 100644 --- a/model/registry/code.yaml +++ b/model/registry/code.yaml @@ -1,7 +1,7 @@ groups: - id: registry.code prefix: code - type: span + type: attribute_group brief: > These attributes allow to report this unit of code and therefore to provide more context about the span. attributes: diff --git a/model/registry/destination.yaml b/model/registry/destination.yaml index 99adf1a872..c05a0c992a 100644 --- a/model/registry/destination.yaml +++ b/model/registry/destination.yaml @@ -1,5 +1,5 @@ groups: - - id: destination + - id: registry.destination prefix: destination type: attribute_group brief: > diff --git a/model/registry/k8s.yaml b/model/registry/k8s.yaml index ca878b8fd8..c4bfcd4765 100644 --- a/model/registry/k8s.yaml +++ b/model/registry/k8s.yaml @@ -1,7 +1,7 @@ groups: - id: registry.k8s prefix: k8s - type: resource + type: attribute_group brief: > Kubernetes resource attributes. attributes: diff --git a/model/registry/server.yaml b/model/registry/server.yaml index f47174dda2..d6927fe98a 100644 --- a/model/registry/server.yaml +++ b/model/registry/server.yaml @@ -1,5 +1,5 @@ groups: - - id: server + - id: registry.server prefix: server type: attribute_group brief: > diff --git a/model/registry/source.yaml b/model/registry/source.yaml index 2f9a967919..077da82310 100644 --- a/model/registry/source.yaml +++ b/model/registry/source.yaml @@ -1,5 +1,5 @@ groups: - - id: source + - id: registry.source prefix: source type: attribute_group brief: > diff --git a/model/registry/thread.yaml b/model/registry/thread.yaml index 688b0ec8e2..9c99772b9b 100644 --- a/model/registry/thread.yaml +++ b/model/registry/thread.yaml @@ -1,7 +1,7 @@ groups: - id: registry.thread prefix: thread - type: span + type: attribute_group brief: > These attributes may be used for any operation to store information about a thread that started a span. attributes: