Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor-specific database attributes that are also used in metrics should be moved out of database/spans.yaml #1431

Open
trask opened this issue Sep 25, 2024 · 1 comment
Assignees
Labels

Comments

@trask
Copy link
Member

trask commented Sep 25, 2024

Vendor-specific database attributes that are also used in metrics should be moved out of database/spans.yaml, e.g.

- id: db.mssql
type: span
extends: db.sql
brief: >
Attributes for Microsoft SQL Server
attributes:
- ref: db.namespace
sampling_relevant: true
brief: The name of the database, fully qualified within the server address and port.
note:
When connecting to a default instance, `db.namespace` SHOULD be set to the name of
the database. When connecting to a [named instance](https://learn.microsoft.com/sql/connect/jdbc/building-the-connection-url#named-and-multiple-sql-server-instances),
`db.namespace` SHOULD be set to the combination of instance and database name following the `{instance_name}.{database_name}` pattern.
For commands that switch the database, this SHOULD be set to the target database (even if the command fails).
examples: ["instance1.products", "customers"]

@trask
Copy link
Member Author

trask commented Sep 25, 2024

and type changed from span to attribute_group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Post Stability
Development

No branches or pull requests

2 participants