Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should metrics description be a full sentence? #897

Open
reyang opened this issue Nov 22, 2022 · 4 comments
Open

Should metrics description be a full sentence? #897

reyang opened this issue Nov 22, 2022 · 4 comments
Assignees

Comments

@reyang
Copy link
Member

reyang commented Nov 22, 2022

OpenMetrics provided such example: https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#overall-structure

image

The current metrics semantic convention is different (and inconsistent):

image

Ask:

  1. Make it consistent at least for the semantic conventions that are in scope for the initial stable release.
  2. Align with OpenMetrics, description should have the first letter uppercase, and end with ..

Additional Ask (not blocking):

  1. The build tool should fail/block the CI if there is any description not following the convention/rule.
@carlosalberto
Copy link
Contributor

Looks like a good, non-polemical improvement to make.

@trask trask assigned reyang and unassigned arminru Feb 8, 2023
@trask
Copy link
Member

trask commented Feb 8, 2023

@reyang do you think this is a blocker for HTTP stability?

@reyang
Copy link
Member Author

reyang commented Feb 9, 2023

I don't think so, worst case I'll send a small PR just to fix the HTTP metrics descriptions (to align with OpenMetrics convention). Assigning this to myself.

@reyang
Copy link
Member Author

reyang commented Feb 9, 2023

Update: I've scanned through the HTTP metrics semantic conventions and confirmed that all descriptions are now aligned with OpenMetrics convention, so it is not blocking HTTP semantic convention stability.

@trask FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants