Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] How should events be represented in semantic conventions (one per file or one per namespace) #925

Closed
MSNev opened this issue Apr 15, 2024 · 6 comments
Assignees
Labels
area:event enhancement New feature or request

Comments

@MSNev
Copy link
Contributor

MSNev commented Apr 15, 2024

Area(s)

area:event

Is your change request related to a problem? Please describe.

Description

This issue is a discussion into how should events be described within semantic conventions, there are several options

  • One event per event (the client / event preference), but will require additional naming
  • One file per namespace, eg all "browser" events should be within the same file
  • Leave it up to the event domain as it might depend.

We currently have a mixture with the following 2 PR's open which are showing the basic 2 options

Describe the solution you'd like

One per file

When using one event per file we should have some file / folder naming conventions to avoid accidentally creating duplicate events with the same name but located in different sections / files of semantic conventions.

Proposals

Note: the <domain> is the "area" where the events is created / generated and will most likely be related to the namespace of the event.

  • have a folder structure with the namespace

    • docs/<domain>/the/namespace/eventname.md
    • docs/<domain>/the.namespace/eventname.md
    • docs/events/the/namespace/eventname.md
    • docs/events/the.namespace/eventname.md
  • have the filename be full qualified

    • docs/<domain>/the,namespace.eventname.md
    • docs/events/the,namespace.eventname.md

Questions

  • Should the events be "grouped" together (a single events folder) or by domain mobile / browser

One file per namespace

This enables all related events to be grouped together and leaves the naming so all events are in a single file events.md

Proposals

Note: the <domain> is the "area" where the events is created / generated and will most likely be related to the namespace of the event. (mobile, browser)

  • have a folder structure with the namespace
    • docs/<domain>/events.md

One possible downside of this approach is that when / if events become generic they will completely change their location.

Describe alternatives you've considered

No response

Additional context

No response

@MSNev
Copy link
Contributor Author

MSNev commented Apr 15, 2024

Basic Voting Emoji's

👍 - Require a single file per event
🚀 - Require Single file per domain (all events of a namespace / domain should be in a single file events.md)
👀 - Leave it up to the event domain as it will depend (defer the discussion)

@MSNev
Copy link
Contributor Author

MSNev commented Apr 15, 2024

Where should the events be located in
👍 - a single location docs/events (docs/events/<domain>)
👀 - a location based on the event domain (/docs/mobile/, /docs/browser/, /docs/xxxxx/ )
☹️ - no preference, just don't clash with existing folders

@MSNev
Copy link
Contributor Author

MSNev commented Apr 15, 2024

Other options for the above exist as well, so please provide other preferences if you have them.

@trask trask changed the title [Discussion] How should events be represented in semantic conventions (one per fille or one per namespace) [Discussion] How should events be represented in semantic conventions (one per file or one per namespace) Apr 22, 2024
@lquerel
Copy link
Contributor

lquerel commented Apr 22, 2024

In the "one file per namespace" section
One possible downside of this approach is that when / if events become generic they will completely change their location.

How does this not affect the proposal of one event per file? I don't really see any difference in this aspect between the two approaches.

@lmolkova
Copy link
Contributor

lmolkova commented Apr 29, 2024

Event definition is part of some other domain. E.g. we're going to define a bunch of events for LLM.
LLM events should be defined somewhere next to LLM spans and metrics, maybe even in the same file.

So my strong preference is on

👀 - Leave it up to the event domain as it will depend

or

👀 - a location based on the event domain

which seem like the same option.

@lmolkova
Copy link
Contributor

lmolkova commented Oct 7, 2024

Fixed in #1345

@lmolkova lmolkova closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:event enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

5 participants