Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge *.cpu.state attributes to a common cpu.mode attribute #1026

Merged
merged 18 commits into from
Jun 26, 2024

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented May 10, 2024

Fixes #840

Changes

This PR introduces a common cpu.state cpu.mode attribute which is a converged attribute from the system.cpu.state, process.cpu.state and container.cpu.state.

Merge requirement checklist

@ChrsMark ChrsMark requested review from a team May 10, 2024 10:07
@ChrsMark ChrsMark self-assigned this May 10, 2024
@ChrsMark ChrsMark requested a review from a team May 10, 2024 10:21
@ChrsMark ChrsMark force-pushed the merge_cpu_states branch 2 times, most recently from de27ecd to dbd49a4 Compare May 10, 2024 13:13
model/registry/cpu.yaml Outdated Show resolved Hide resolved
model/registry/deprecated/process.yaml Outdated Show resolved Hide resolved
model/registry/deprecated/system.yaml Outdated Show resolved Hide resolved
model/registry/deprecated/container.yaml Outdated Show resolved Hide resolved
.chloggen/merge_cpu_states.yaml Outdated Show resolved Hide resolved
@ChrsMark ChrsMark force-pushed the merge_cpu_states branch 2 times, most recently from 57eee6d to beb92b9 Compare May 13, 2024 08:45
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think you need to re-generate the make generate-gh-issue-templates though

@ChrsMark
Copy link
Member Author

Thank's @joaopgrassi. For some reason the make generate-gh-issue-templates does not change anything 🤔 .

@ChrsMark
Copy link
Member Author

@open-telemetry/semconv-system-approvers could you take a look and specifically into the #1026 (comment)? Thank's.

model/registry/cpu.yaml Outdated Show resolved Hide resolved
@ChrsMark
Copy link
Member Author

Changed to cpu.mode @lmolkova @trisch-me @open-telemetry/semconv-system-approvers feel free to take another look :)

schema-next.yaml Outdated Show resolved Hide resolved
ChrsMark and others added 6 commits June 21, 2024 11:56
Co-authored-by: Alexandra Konrad <alexandra.konrad@elastic.co>
Co-authored-by: Alexandra Konrad <alexandra.konrad@elastic.co>
Co-authored-by: Alexandra Konrad <alexandra.konrad@elastic.co>
Co-authored-by: Alexandra Konrad <alexandra.konrad@elastic.co>
Co-authored-by: Alexandra Konrad <alexandra.konrad@elastic.co>
Co-authored-by: Alexandra Konrad <alexandra.konrad@elastic.co>
@trisch-me
Copy link
Contributor

You need to regenerate registry to update md files to fix the issue

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left a few minor comments.

model/metrics/system-metrics.yaml Outdated Show resolved Hide resolved
model/metrics/system-metrics.yaml Outdated Show resolved Hide resolved
model/registry/cpu.yaml Show resolved Hide resolved
schema-next.yaml Show resolved Hide resolved
ChrsMark and others added 5 commits June 25, 2024 09:54
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Co-authored-by: Braydon Kains <93549768+braydonk@users.noreply.github.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@joaopgrassi joaopgrassi merged commit db1b84d into open-telemetry:main Jun 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Consider merging *.cpu.state metric attributes
7 participants