Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VCS metrics from Github receiver #1383
base: main
Are you sure you want to change the base?
Add VCS metrics from Github receiver #1383
Changes from all commits
44a1c81
700412a
4d8e3a9
9bd4a95
592483f
238c764
ef91dfa
f712312
8c2e8a7
a148a4e
347b15b
afaa1f5
5a9ffe7
2da96a5
c232041
aab9f90
41543cd
7f35251
a5eff73
7107911
15fe1fb
30c8fdb
344eeed
cfcdaf1
e174ef3
7d114d3
b92cc08
84b2b6a
163e498
d2ce62f
536a2a7
cfffb4f
0e02a47
1a89934
b5c4660
dafdad7
3e122e8
513ae8b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a histogram?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you feel about the claim, here which says that we can form a histogram out of any fundamental instrument type? For "lines_delta" specifically, it sounds like an Counter-- if you were to aggregate a number of refs or repositories together, would you want to sum the lines added and removed.
Is there an attribute to distinguish "add" from "remove" in this situation? If you were to aggregate-away this attribute, would you expect to have a single number that is added+removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider using histogram
vcs.repository.ref.revisions.delta
(vcs.ref.revisions.lag
, etc) and make ahead/behind an attribute.Hopefully at some point negative measurements will be supported - open-telemetry/opentelemetry-specification#4155 (comment) and life would be even easier - no additional attribute will be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I have changed back any histograms to gauge.
Let's discuss on Monday how to proceed regarding instrument type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we instead report creation time for each branch? Then people can derive other things including deltas from it. It could also be useful for tags. E.g.
vcs.ref.created|creation_time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrielp what's your opinion?