Skip to content

Commit

Permalink
Use LFS to parse replay logs from file paths (openconfig#2332)
Browse files Browse the repository at this point in the history
* Add .gitattributes to enable LFS

* Replay tests to use file paths, not URLs

* Remove errant characters

* Parse -> ParseFile
  • Loading branch information
greg-dennis authored Nov 1, 2023
1 parent f9c0878 commit 232aa5d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.pb filter=lfs diff=lfs merge=lfs -text
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ func TestMain(m *testing.M) {
}

func TestReplay(t *testing.T) {
const logFile = "https://github.com/openconfig/featureprofiles/raw/main/feature/experimental/replay/tests/diff_command_trees/grpclog.pb"
const logFile = "grpclog.pb"
t.Logf("Parsing log file: %v", logFile)
rec := replayer.ParseURL(t, logFile)
rec := replayer.ParseFile(t, logFile)

dut := ondatra.DUT(t, "dut")
portMap := map[string]string{}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ func TestMain(m *testing.M) {
}

func TestReplay(t *testing.T) {
const logFile = "https://github.com/openconfig/featureprofiles/raw/main/feature/experimental/replay/tests/presession_test/grpclog.pb"
const logFile = "grpclog.pb"
t.Logf("Parsing log file: %v", logFile)
rec := replayer.ParseURL(t, logFile)
rec := replayer.ParseFile(t, logFile)

dut := ondatra.DUT(t, "dut")
portMap := map[string]string{}
Expand Down

0 comments on commit 232aa5d

Please sign in to comment.